email.data and email.subject signature breaking change

VulcanJS / Vulcan

🌋 A toolkit to quickly build apps with React, GraphQL & Meteor

http://vulcanjs.org

MIT License

7.98k stars 1.88k forks source link

email.data and email.subject signature breaking change #2150

Open mousetraps opened 5 years ago

mousetraps commented 5 years ago

If the email function definitions included data(variables) or subject(data), it is required to change to the new object. Otherwise you end up with a UnhandledPromiseRejectionWarning, and the email does not get sent. https://github.com/VulcanJS/Vulcan/commit/75eb7f3c8143aad978f64403ce90332b791fc06f#diff-6707e3f27ab9da3f2af3e0d7c44609e2R144

Additionally, the documentation should be updated to reflect the new behavior.

SachaG commented 5 years ago

Do you think we should make it backwards-compatible, or is it enough to update the docs? Usually we try to avoid breaking changes, but in this case I don't know if that's a widely used feature so it might be ok?