Open mousetraps opened 5 years ago
If the email function definitions included data(variables) or subject(data), it is required to change to the new object. Otherwise you end up with a UnhandledPromiseRejectionWarning, and the email does not get sent. https://github.com/VulcanJS/Vulcan/commit/75eb7f3c8143aad978f64403ce90332b791fc06f#diff-6707e3f27ab9da3f2af3e0d7c44609e2R144
data(variables)
subject(data)
UnhandledPromiseRejectionWarning
Additionally, the documentation should be updated to reflect the new behavior.
Do you think we should make it backwards-compatible, or is it enough to update the docs? Usually we try to avoid breaking changes, but in this case I don't know if that's a widely used feature so it might be ok?
If the email function definitions included
data(variables)
orsubject(data)
, it is required to change to the new object. Otherwise you end up with aUnhandledPromiseRejectionWarning
, and the email does not get sent. https://github.com/VulcanJS/Vulcan/commit/75eb7f3c8143aad978f64403ce90332b791fc06f#diff-6707e3f27ab9da3f2af3e0d7c44609e2R144Additionally, the documentation should be updated to reflect the new behavior.