Code Quality Issues

[TrevBid]

These items were found using a static analysis scanner called SonarQube. We used the community edition to identify code quality issues.

[TrevBid]

• [ ] Make sure that using this pseudorandom number generator is safe here. File: app/assets/javascripts/global/shuffle.js , Line 3, uses Math.random
• [ ] Empty function. File: app/assets/javascripts/about/tour.js, Line 23.
• [ ] Unused table variable. File: app/assets/javascripts/developers/show.js, Line 136.
• [ ] Unused import of $. File: app/assets/javascripts/filepaths/dev-pie.js, Line 1
• [ ] Commented out code remaining. File: app/assets/javascripts/filepaths/dev-pie.js, Lines 20-21
• [ ] Unused import of '_'. File: app/assets/javascripts/filepaths/keyCommitsTable.js, Line 2
• [x] Commented out code remaining. File: app/assets/javascripts/global/articleListing.js, Lines 1-2
• [x] Commented out code remaining. File :app/assets/javascripts/global/dataToPrettyStrings.js, line 27-28
• [x] Commented out code remaining. File: app/assets/javascripts/vhp.js, Lines 18-19
• [x] Commented out code remaining. File: app/assets/javascripts/vulnerabilities/index.js, Line 3,8
• [ ] Unreachable code. File: app/assets/javascripts/vulnerabilities/timeline.js, Line 748 (SonarQube claiming due to break)
• [ ] Unused imports. File: app/assets/javascripts/welcome/welcome.js, Lines 1 and 2
• [ ] Commented out code remaining. File: app/assets/javascripts/welcome/welcome.js, Lines 4-15, 18-23
• [x] Duplicate code (font-size). File: app/assets/stylesheets/timeline.scss, Line 19
• [ ] Default clause missing for case statement. File: test/system/home/content_test.rb, Line18
• [x] Duplicate code. File: vendor/assets/stylesheets/responsive-datatables.scss, Line 121 and 124