Vydia / react-native-background-upload

Upload files in your React Native app even while it's backgrounded. Supports Android and iOS, including camera roll assets.

MIT License

720 stars 325 forks source link

Safe get kotlinVersion #320

Open diegomichell opened 1 year ago

diegomichell commented 1 year ago

Summary

There was an error on the newer build tools version because Kotlin version was not able to be upgraded and provided to this package from the root of the project.

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS	Implemented
iOS	✅❌
Android	✅❌

Checklist

[X] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I updated the typed files (TS and Flow)
[ ] I've added Detox End-to-End Test(s)
[ ] I've created a snack to demonstrate the changes: LINK HERE

cchampou commented 9 months ago

I'm using this branch on our application it seems to build and work fine ! I'd love to see it merged and published

1mike12 commented 6 months ago

@cchampou do you have write access? or is the og author AWOL?

cchampou commented 6 months ago

@cchampou do you have write access? or is the og author AWOL?

@1mike12 I do not have write access unfortunately

daltonwignall commented 6 months ago

Just tacking on that I would love to see this one merged as well. Currently running into the same issue while trying to upgrade to RN 73.x.

1mike12 commented 6 months ago

Honestly it just seems like we're going to have to use the fixed Branch from @cchampou instead of relying on the actual project since the owner is not here anymore

On Fri, Dec 22, 2023, 12:29 daltonwignall @.***> wrote:

Just tacking on that I would love to see this one merged as well. Currently running into the same issue while trying to upgrade to RN 73.x.

— Reply to this email directly, view it on GitHub https://github.com/Vydia/react-native-background-upload/pull/320#issuecomment-1867965854, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGAT4QO3LHRKBYEWYCIUE3YKXGRVAVCNFSM6AAAAAATCSNJD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRXHE3DKOBVGQ . You are receiving this because you were mentioned.Message ID: @.***>