search

W3ndige / karton-similarity

Aurora karton for similiarity matching.
GNU Affero General Public License v3.0
2 stars 0 forks source link

Hardcoded redis configuration for datasketch.MinHashLSH #1

Closed psrok1 closed 3 years ago

psrok1 commented 3 years ago

"redis" configuration should be derived from Karton configuration (self.config.redis_config). Currently it doesn't work in environments with different Redis server hostname (not karton-playground-alike)

https://github.com/W3ndige/karton-similarity/blob/98188fbb6f0224d788b2b507fbf94d7b5b22d5c8/karton/similarity/similarity.py#L85-L93

W3ndige commented 3 years ago

Good catch! Somehow I've missed that before publishing. :thinking: