search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.19k stars 178 forks source link

Image Blend by Mask: mask input takes image instead #105

Closed Bocian-1 closed 1 year ago

Bocian-1 commented 1 year ago

image

WASasquatch commented 1 year ago

Yes, cause it's for raster blending of images, not diffusion masking. Use a Masks to Images node if you want to use a mask.

Bocian-1 commented 1 year ago

Well, it is a bit confusing at first, not gonna lie. Not like I have any good idea of how to help it though.

WASasquatch commented 1 year ago

I don't see how. It's a image blending node. Like Photoshop and such. You use raster masks. Mask format is really just in the way and a hassle to deal with on the backend and actually serves no purpose. Handling tensor conversion should be done from one standard format so you can use them whenever. Filter nodes, preview nows, etc.

Bocian-1 commented 1 year ago

I mean that it being labelled as 'mask' but requiring 'image' is what confused me specifically, that's why I thought it was an error in the first place. Changing the labels around to avoid that seems a bit tricky to do. That is all.

WASasquatch commented 1 year ago

Ohh I see. Yeah that could be renamed. I ahd thought of that before but it's not graceful in that it will break everyone's workflows.

Aliases for fields would be cool. I should try and suggest that.