search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

Pinned version of transformers in requirements.txt breaks other custom nodes #313

Closed sesopenko closed 9 months ago

sesopenko commented 9 months ago

Pinning transformers to the older version breaks other custom nodes, particularly ones which depend on onnxruntime-gpu. In particular, downgrading the transformers version to 4.26.1 results in onnxruntime defaulting to the CPU instead of the GPU, slowing down various GPU dependant processes of other nodes.

Steps to reproduce:

  1. Install pytorch following official instructions
  2. pip install onnxruntime-gpu
  3. clone was-node-suite-comfyui
  4. cd was-node-suite-comfyui && pip install -r requirements.txt
  5. python -c "import onnxruntime as ort;print(ort.get_device())"

Expected results:

Should output GPU

Actual results:

Outputs CPU, causing tasks such as openpose detection for DWPose to run on the CPU, as well as many other tasks from other nodes depending on the GPU.

sesopenko commented 9 months ago

I'm not actually sure it's because the transformers version is causing onnxruntime-gpu to fail. I figured out a workaround for now of reinstalling onnxruntime-gpu after this module's installed.