WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

Image Save: Workflow is saved to webp even if it's not available #340

Open Chaoses-Ib opened 8 months ago

Chaoses-Ib commented 8 months ago

Image Save will save Workflow regardless of whether it is available. And if Workflow exists, ComfyUI's web UI will use it instead of Prompt even if it's NUL. This prevents the prompt to be loaded into the web UI.

https://github.com/WASasquatch/was-node-suite-comfyui/blob/33534f2e48682ddcf580436ea39cffc7027cbb89/WAS_Node_Suite.py#L7227-L7238

WASasquatch commented 8 months ago

Sounds like a fix to reported to ComfyUI loader side, to have sanity checks for if there is actually data in a key, especially stuff like "workflow" shared by other software. Workflows in image exif isn't even exclusive to ComfyUI.

On Fri, Feb 2, 2024, 12:18 PM Chaoses-Ib @.***> wrote:

Image Save will save Workflow regardless of whether it is available. And if Workflow exists, ComfyUI's web UI will use it instead of Prompt even if it's NUL. This prevents the prompt to be loaded into the web UI.

https://github.com/WASasquatch/was-node-suite-comfyui/blob/33534f2e48682ddcf580436ea39cffc7027cbb89/WAS_Node_Suite.py#L7227-L7238

— Reply to this email directly, view it on GitHub https://github.com/WASasquatch/was-node-suite-comfyui/issues/340, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZEZPEP7TTBAVS3MMNG2DYRVCYHAVCNFSM6AAAAABCXHY7I6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYTKNZSG44TQMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>