WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.23k stars 178 forks source link

Text Save Improvements #483

Closed Vigilence closed 1 month ago

Vigilence commented 1 month ago

I like the save text node but noticed some issues that needed improvement such as no ability to add a suffix, the bug of no proper incremental files being saved with a delimiter. So if I don't use a delimiter the files are numbered after the total amount of files in the save folder. So if the folder has 124 images then the txt file saves as 125. A filter was added to ignore other files except .txt.

The code edits were required so that batch saving of .txt files can be done, with incremental files starting at 1, with the ability to add a prefix so that the match the image that caption was created from.

Screenshot 2024-09-21 212008 Screenshot 2024-09-21 212118 Screenshot 2024-09-21 212336

WASasquatch commented 1 month ago

Is there anyway you can order the widgets so it doesn't break old workflows? I know this node particularly is used in services. I have broken some nodes this way in the past and screwed up people's sites when they updated.

Vigilence commented 1 month ago

So the proper order should be exactly what was before the edit, with the suffix input at the very end?


From: WAS @.> Sent: Sunday, October 6, 2024 1:23 PM To: WASasquatch/was-node-suite-comfyui @.> Cc: Vigilence @.>; Author @.> Subject: Re: [WASasquatch/was-node-suite-comfyui] Text Save Improvements (PR #483)

Is there anyway you can order the widgets so it doesn't break old workflows? I know this node particularly is used in services. I have broken some nodes this way in the past and screwed up people's sites when they updated.

— Reply to this email directly, view it on GitHubhttps://github.com/WASasquatch/was-node-suite-comfyui/pull/483#issuecomment-2395515722, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFNZ5AT6F5GAXQFXWF6JIPTZ2FWXZAVCNFSM6AAAAABPOPVOJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGUYTKNZSGI. You are receiving this because you authored the thread.Message ID: @.***>

WASasquatch commented 1 month ago

Thank you!