Closed ivan-tolkunov closed 1 month ago
Have you tested all OpenCV related code, and functions? A lot of CV 1.x stuff isn't compatible with 2.0, even with stuff like Ultralytics.
I tested the following: opencv
other
Also, the latest version of opencv
and ultralytics
supports numpy2
OpenCV Release 84 |
Ultralytics Release 8.3.4
@WASasquatch Hey, are there any updates?
Thanks for the work, we'll see if there is any other issues.
According to blame of
requirements.txt
the<=4.7.0.72
restriction was added more than a year ago.Since then, numpy 2 became a thing, and opencv was changed to use numpy 2. Lots of other Comfy plugins use opencv without version restrictions, and pip just installs the latest >= 4.10.
But when installing was-node-suite, because of the
<=4.7.0.72
restriction, it downgrades opencv-python-headless to version 4.7.0.72, which uses numpy 1. Pip gladly removes opencv-python-headless 4.10+ and installs the older version, but it doesn't downgrade numpy. Then in the runtime, when importingcv
, the import fails with:I couldn't figure out why
<=4.7.0.72
restriction was needed > year ago. Things seem to work fine without it.