search

WASdev / standards.jsr352.jbatch

Home of 'jbatch', a compatible implementation of the Jakarta Batch specification (and the former Reference Implementation for the JSR 352, Batch Applications for the Java Platform specification).
Other
21 stars 18 forks source link

#74 Fix warning in CDI 3 and error in 4 #75

Closed arjantijms closed 2 years ago

arjantijms commented 2 years ago

Fixes #74

Provide an Id for the addAnnotatedType call.

Signed-off-by: arjantijms arjan.tijms@gmail.com

scottkurz commented 2 years ago

Hi @arjantijms .. thank you. As you can see I hadn't tried on CDI 4 yet.

One slightly annoying legal detail. There is a CLA for contributing to the project (rather than DCO). If you don't want to bother with that I'll just fix it myself and thank you via email to the ML ! But if you want me to merge the PR please fill out either:

Note the CLA references the former spec/TCK projects, which are obsolete, superseded by the EE4J projects, as well as the jbatch impl which is still active.

Thank you.

arjantijms commented 2 years ago

@scottkurz I was already wondering where the CLA could be found ;) Thanks for the link, I filled it out and mailed it to you.

scottkurz commented 2 years ago

Thank you @arjantijms . We do need to move up to the EE 10 deps like CDI 4 but will wait just a bit for the deps to stabilize.