search

WIAS-PDELib / ExtendableGrids.jl

MIT License
21 stars 11 forks source link

Re-type argument in local-to-global transformations #62

Closed Da-Be-Ru closed 1 month ago

Da-Be-Ru commented 1 month ago

The local-to-global eval_trafo! functions currently operate on the Vector type.

However, in trying to extend VoronoiFVM.edgevelocities to accomodate velocity fields provided by ExtendableFEM.jl, we need to make use of coordinate transformations on vectors previously declared as StaticArrays which are not a subtype of Vector.

It makes sense to adjust the type of x then and I suppose AbstractArray is a safe bet. All tests run through for me on this.

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.73%. Comparing base (06a2f11) to head (eee8d7d). Report is 86 commits behind head on master.

Files with missing lines Patch % Lines
src/l2gtransformations.jl 42.85% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #62 +/- ## ========================================== + Coverage 73.01% 73.73% +0.71% ========================================== Files 27 32 +5 Lines 4239 4907 +668 ========================================== + Hits 3095 3618 +523 - Misses 1144 1289 +145 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

j-fu commented 1 month ago

Completely reasonable IMHO, thanks! @chmerdon , we should merge and make a new patch version.