search

WMCAlliance / BukkitIRCd

BukkitIRCd was an IRC bridge plugin for Minecraft servers running Bukkit. It creates individual 'bot' users for every player to allow seamless communication.
https://wma.im
Other
5 stars 6 forks source link

Kick messages contain newline #109

Closed Rikairchy closed 9 years ago

Rikairchy commented 10 years ago

When kicking a user, either using !kick in the staff channel or in game, it sends a newline in 1.7.4, causing inspIRCd to netsplit. Not Bukkit's default kick command seems to work. A slight .replace should fix it, right?

https://github.com/Bukkit/Bukkit/blob/08c71f24abc214bb6995a7266593dbb2217ddde1/src/main/java/org/bukkit/command/defaults/KickCommand.java

Line 40: Command.broadcastCommandMessage(sender, "Kicked player " + player.getName() + ". With reason:\n" + reason);

BlaneyXYZ commented 9 years ago

I wasn't able to replicate this, mind trying again for me please.

WizardCM commented 9 years ago

Yeah I'm not seeing this on InspIRCd-2.0 either, and didn't have an issue from 1.7.2 to 1.8.3.

Rikairchy commented 9 years ago

Bukkit fixed this about a week after I posted an issue in their forums pertaining to this. You guys are slightly late to the party.