search

WOA-Project / WOA-Deployer-Lumia

Making your Lumias great again!
MIT License
481 stars 71 forks source link

In the PartitionCleaner.cs there are still dependencies to volume.label. It should use partition.name #19

Closed paule96 closed 5 years ago

paule96 commented 5 years ago

Describe the bug

If you deploy the emergency-files to your lumia950xl with the WPI, it can happend that the last volume don't get the label "Data". This shouldn't be a problem for WOA because we use the GPT partition name instead of the volume name. But one single line in the PartitionCleaner.cs use the volume name. This result in an error in Phone disk preparation failed in the frontend that stop the deployment. If you look in the log you see the full error:

Deployer.FileSystem.PartitioningException: The label of the last partition should be 'Data' and it's ''
   bei Deployer.Lumia.PartitionCleaner.<EnsureDataIsLastPartition>d__3.MoveNext()

To Reproduce

Steps to reproduce the behavior:

  1. Deploy your Lumia950XL with the emergency-files or with the Windows Device Recovery Tool
  2. Open the disk management on check if the last partition have the label Data
    • if not remove that label over the propertys
  3. try to deploy your WinARM via WOA and you see the error.

Expected behavior No error or a message that ask me, if it should be change the volume label.

Current workaround

go in the disk management and change the labe of the last partition to Data. Make sure you use the last partition.

If nobody grab this in the next 8h I start working on the fix by myself. But now I go to sleep. Good night internet 😎

SuperJMN commented 5 years ago

Fixed by https://github.com/WOA-Project/WOA-Deployer-Lumia/commit/038bc1751604c96f4510a9e00caffbea9f93cc54