Script adding {{disambig}} on accepted pages even when it's already there

WPAFC / afch

Yet another Articles for creation helper script -- ACTIVE DEVELOPMENT NO LONGER HAPPENS IN THIS REPOSITORY AND HAS MOVED TO

https://github.com/WPAFC/afch-rewrite

9 stars 3 forks source link

Script adding {{disambig}} on accepted pages even when it's already there #144

Closed earwig closed 11 years ago

earwig commented 11 years ago

See https://en.wikipedia.org/w/index.php?title=F%C4%B1st%C4%B1kl%C4%B1&diff=prev&oldid=571336488.

theopolisme commented 11 years ago

odd, I was under the impression that @wikipedia-mabdul had written a fix for this https://github.com/WPAFC/afch/blob/abb1816d93d992e8e98ea2bfde56b33ae1cac634/src/submissions.js#L676-L677

Regardless, will look into this evening.

theopolisme commented 11 years ago

Fixed in above commit

wikipedia-mabdul commented 11 years ago

uhm, ok, crazy bug... (btw: was that safari? XD)

theopolisme commented 11 years ago

No, the issue is that you were using the g modifier on a regex that you were testing, so it returned different results every time, see http://stackoverflow.com/a/2630538/1934901

wikipedia-mabdul commented 11 years ago

o.O...