Minor issue: cononicalize install locations on macOS (and Linux?)

WRF-CMake / wrf

🌀 The Weather Research and Forecasting (WRF) model with CMake support

Other

44 stars 3 forks source link

Minor issue: cononicalize install locations on macOS (and Linux?) #27

Closed zbeekman closed 5 years ago

zbeekman commented 5 years ago

I haven't tried make install on linux yet, but on macOS it puts executables into an abnormal directory structure: <prefix>/{main,test}.

Also, .exe suffix is not commonly used outside of windows. CMake should handle that automatically for you.

As for the directory structure, I would recommend using GNUInstallDirs on macOS and Linux and putting binaries into ${CMAKE_INSTALL_BINDIR} and the test/examples directory can be installed into ${CMAKE_INSTALL_DATADIR}/wrf.

letmaik commented 5 years ago

All great suggestions, and of course we would never come up ourselves with such a weird structure and executable extensions on non-Windows. Welcome to the world of WRF :) We need to keep these exact folders and filenames to match what the existing build system does, so that users can keep their work flows and follow the original documentation and use WRF-CMake as a drop-in. Sorry :/