search

Waboodoo / HTTP-Shortcuts

Android app to create home screen shortcuts that trigger arbitrary HTTP requests
https://http-shortcuts.rmy.ch
MIT License
1.17k stars 113 forks source link

Adaptive Icon #310

Closed xmha97 closed 1 year ago

xmha97 commented 2 years ago

Please use an adaptive icon.

Waboodoo commented 2 years ago

The app already uses an adaptive icon.

xmha97 commented 2 years ago

On Xiaomi phones, there is no animation when the icon of this app moves.

xmha97 commented 2 years ago

https://user-images.githubusercontent.com/23485114/202902469-82338413-29d9-407f-b66d-4a040baf55c5.mp4

xmha97 commented 2 years ago

@Waboodoo Please reopen this issue.

Waboodoo commented 2 years ago

Interesting... I cannot reproduce this on any of my devices, so I suspect this is specific to Xiaomi. I have an idea what might be the cause, but as I can't test it I can't guarantee that that will fix it.

xmha97 commented 2 years ago

@Waboodoo When will the new version be released?

Waboodoo commented 2 years ago

I don't know yet. I still have some other bugs I need to look into that I want to have fixed in the next release. If I find the time I might be able to release within the next week, but it might also take longer.

xmha97 commented 2 years ago

OK, thanks for your reply.

Waboodoo commented 1 year ago

Version 2.26.0 is now available for beta testing, which includes the fix for this issue, assuming that it actually fixes it. You can join the beta program here: https://play.google.com/apps/testing/ch.rmy.android.http_shortcuts

xmha97 commented 1 year ago

Thank you, but the issue is not fixed:

https://user-images.githubusercontent.com/23485114/205011490-aeea1530-1702-427c-8ddc-1e67b9d026ca.mp4

Waboodoo commented 1 year ago

Unfortunately, then I really don't know how to fix this. It works on my test devices, and I don't see what I'm doing wrong.

xmha97 commented 1 year ago

This problem is not in any of the apps that I installed, for example: https://github.com/mueller-ma/Coffee If you release debug builds, I'll test them.

Waboodoo commented 1 year ago

I honestly don't know what is different in my app. I made some more small tweaks, here's an APK build for it that you can try: https://http-shortcuts.rmy.ch/files/app-universal-release.apk

If that does not solve the issue then I'm giving up, as I don't want to spend this much time on something so minor.

xmha97 commented 1 year ago

Thanks for this build, but unfortunately the problem is not solved, if you want, close this issue.

Waboodoo commented 1 year ago

Ok, shame, I'm out of ideas. I will close this as Won't Fix then and assume that this is another case of Xiaomi doing weird things.

Jesse205 commented 1 year ago

Screenshot_20230818_193426_com.huawei.android.launcher.jpg Abnormal display of desktop icons on Huawei devices.

Because the software placed the icon under drawable instead of mipmap anydpi v26 Screenshot_20230818_193327.jpg

The correct approach is to use Android Studio to generate icons, and Studio will place them in the correct location.

Waboodoo commented 1 year ago

The ic_launcher.xml file is already placed inside mipmap-anydpi-v26. It's just the foreground drawable that's in the drawable directory, but it has to be there as it is a vector drawable and thus cannot be moved to the mipmap directory.