[BUG] Executing a shortcut and PiP (Picture in Picture)

Waboodoo / HTTP-Shortcuts

Android app to create home screen shortcuts that trigger arbitrary HTTP requests

https://http-shortcuts.rmy.ch

MIT License

1.17k stars 113 forks source link

[BUG] Executing a shortcut and PiP (Picture in Picture) #332

Closed haitham506 closed 1 year ago

haitham506 commented 1 year ago

Hi,

Executing a shortcut from the (Quick Settings Tile) Triggers PiP (Picture in Picture) in the Opened App.

Is it possible to add an option to not Trigger PiP on other Apps when exceuting a shotcut?

Waboodoo commented 1 year ago

I am not able to reproduce this, and I'm also not really sure I understand the issue. Could you perhaps post some screenshots or a screen recording?

haitham506 commented 1 year ago

If you have an App that Auto switch to PiP when you go to home screen or switch to another app (Like Twitch App) you can reproduce it.

Here is a screen recording for it

https://user-images.githubusercontent.com/66400184/219501136-9db7c848-f1ee-46b7-ba40-ca5e004011d0.mp4

Waboodoo commented 1 year ago

I see. I don't think I have any control over this. This is likely a behavior defined either by the Android system itself or by the PiP app. Basically, whenever you trigger a shortcut (no matter how), it will very briefly open the HTTP Shortcuts app and close it again immediately. This means that Android or another app might decide to put the currently active window into PiP mode (if it supports it).

I can see a potential workaround that I could try implementing, but it would only work for very simple shortcuts, i.e., they couldn't use any of these features:

file uploads
Dynamic variables (i.e., variables other than static ones)
Scripting
any form of user interaction, such as asking for confirmation

Would that be the case for your shortcut(s) that you want to trigger through the Quick Settings Tile?

haitham506 commented 1 year ago

Nice, my shortcuts are just a (GET Request) to a URL. Will this workaround work?

Thank you for your quick response :)

Waboodoo commented 1 year ago

I hope it will. I'll have to experiment with this a bit. Can't make any promises when and if I'll be able to add this.

Waboodoo commented 1 year ago

I have implemented a potential fix for this issue in version 2.31.0, which is now available on the beta channel. @haitham506 If you want to give it a try, you can join the beta program.

haitham506 commented 1 year ago

I just updated to the beta version and tested it, ~~the same behavior as before :( but it is faster now~~

edit:

I retested again today after changing some settings and It Works.

Response Handling Must be on Show nothing (run silently) for both. (Which I did try before)
Wait for connection when offline Must be unchecked.

Thank you :smile:

Waboodoo commented 1 year ago

Glad to hear it works now. Yes, the rules for this are very restrictive, your shortcut has to be super simple and the conditions must be "perfect" (e.g., no battery saver or data saver on) for it to work.

If you do need some kind of visual feedback that the shortcut was triggered, you can change the response type to "Toast Popup", and then grant the app permission to display Notifications (which you'll have to do via the system settings, the app itself currently has no UI for this).

haitham506 commented 1 year ago

If you do need some kind of visual feedback that the shortcut was triggered, you can change the response type to "Toast Popup", and then grant the app permission to display Notifications (which you'll have to do via the system settings, the app itself currently has no UI for this).

I just did that, even better now 👍

Thank you so much 😄

haitham506 commented 1 year ago

Hello, I really like the UI in the 3.0 version 👍 ,but this is not working correctly, it doesn't work in the Background anymore. It also shows in the Recent Apps Menu after executing.

Waboodoo commented 1 year ago

Could you elaborate what you mean by "this"? I'm struggling to reproduce an issue. I found one bug related to the quick settings tile, but it would only happen if the shortcut was configured to ask for confirmation before running. Is that perhaps the case for your shortcut?

haitham506 commented 1 year ago

If you have an App that Auto switch to PiP when you go to home screen or switch to another app (Like Twitch App) you can reproduce it.

Here is a screen recording for it

HTTP-Shortcuts.-.PiP.mp4

The same issue here is back in 3.0 and 3.0.1, also now even just Clicking the Quick Settings Tile it self before choosing a shortcut will behave the as the Video attached before + HTTP-Shortcuts will show up in the Recent Apps Menu if I didn't select a shortcut.

There is no ask for confirmation or anything it is just a GET Request shortcut it works fine on 2.31
Here is another screen recording showing the 2 issues:

https://github.com/Waboodoo/HTTP-Shortcuts/assets/66400184/4f779c03-94b6-4e96-9ce5-427f2c33fe27

I hope it is clear 👍

Waboodoo commented 1 year ago

@haitham506 Does the issue still exist in version 3.1.0? I had to do a bit of a hacky workaround, to get this to work. As a result, the picker dialog for selecting the shortcut to run might not be nicely styled, but it should work.

haitham506 commented 1 year ago

@haitham506 Does the issue still exist in version 3.1.0? I had to do a bit of a hacky workaround, to get this to work. As a result, the picker dialog for selecting the shortcut to run might not be nicely styled, but it should work.

It uses the old design but it is now working fine 👍. Thank you for fixing it 🌹