search

WalletConnect / kotlin-walletconnect-lib

library to use WalletConnect with Kotlin or Java
MIT License
147 stars 100 forks source link

Add 'personal_sign' method as part of the main public API #64

Closed amilcar-andrade closed 2 years ago

amilcar-andrade commented 2 years ago

@pedrouid could you review and merge 👍

amilcar-andrade commented 2 years ago

@ligi @rmeissner wondering if it is needed to add a case for this inside of https://github.com/WalletConnect/kotlin-walletconnect-lib/blame/1486aa2d374d2e64614bf6d467a4076f1215d1a0/lib/src/main/kotlin/org/walletconnect/impls/MoshiPayloadAdapter.kt#L96

Even when using a Custom response and calling personal_sign I don't see the method property being set in the JSON that you get back from the server. I do see it for other events like wc_updated wondering if this is set by the wallet connect server.