Ogres should use fat animations to reduce clipping

[ercarp]

Describe your suggestion in full detail below: The ogre ethnicity does not seem to affect weight at all, so even though they look really chunky, their weight is still extremely low which results in the game defaulting to use the non-fat emotes. Which means more clipping occurs.

As an example, here's Cho'gall with a weight of 3.

Click to expand


For contrast, even Llane Wrynn who looks like he's average weight, has a weight stat of 16. So something as low as 3 makes virtually zero sense for ogres.

Click to expand


The majority of fat animations don't trigger unless the character has a weight stat above 50 (some can trigger as low as 20 though, and a few only above 65). For a race as tall and big as the ogres, I think it would make sense for their weight stat to be somewhere between 75 to 100 but this may take some trial and error to figure out the ideal range. However, the ethnicity does use a range of 0.75 to 1.

Default Animation (currently in use) Arms are more inward and clip through the body.

Fat Animation (simulated by adding weight in debug) Arms are flared outward and don't clip as much.

Proposed Fixes

• @MemeWizard suggested adding the weight gain to the race assignment event.
• I (@ercarp) tried to append has_trait = creature_ogre to the fat animations in gfx\portraits\portrait_animations\animations.txt but for some reason this did not work when I tested it in-game. However, given that I'm not a coder, I may have messed up my coding and that's why it didn't work. There might still be a way to do it via here.

Click to expand

The code I used which didn't work. 

[zumbak04]

@MemeWizard suggested adding the weight gain to the race assignment event.

This looks better but we need to make it so obese minuses don't affect ogres or they're countered.