WarwickCIM / ways-py

Python package for the WAYS project.
https://pypi.org/project/ways-py/
GNU General Public License v3.0
1 stars 2 forks source link

SVG-based image comparison #49

Closed rolyp closed 3 years ago

rolyp commented 3 years ago

It might be worth reverting to PNG-based comparisons (as we used for Backfillz) for a more extensional notion of equivalence.

rolyp commented 3 years ago

@edwardchalstrey1 I'm finding comparing outputs as .json (Vega Lite) files a bit suboptimal. When we change our code, and the Vega Lite code changes as a result, it's not clear when the resulting image actually changes too. I'm going to experiment with generating .png or .svg (the latter would be better as it's a text format, and so can be more easily diffed), but I'll probably also retain the ability to generate/compare Vega Lite. (Comparing images will be problematic for other reasons, e.g. the actual change will often be much more obscure than a Vega Lite change.)