search

Warzone2100 / old-trac-import

Archived Import of (old) Warzone 2100 Trac
0 stars 0 forks source link

Random crash, multiplayer game #1334

Closed wzdev-ci closed 14 years ago

wzdev-ci commented 14 years ago

resolution_fixed type_bug | by Dylan Hsu

Error occured on Monday, January 4, 2010 at 18:39:02.

Program: C:\Program Files\Warzone 2100 2.3b5\warzone2100.exe(warzone2100)
Command line: "C:\Program Files\Warzone 2100 2.3b5\warzone2100.exe" 
Version: Version 2.3_beta5 (modified locally)
Distributor: UNKNOWN
Compiled on: Jan  3 2010 18:38:45
Compiled by: GCC 4.4.2
Compiled mode: Release build
Executed on: Mon Jan 04 18:10:09 2010

Pointers: 32bit

Compiled against PhysicsFS version: 1.0.1
Running with PhysicsFS version: 1.0.1

Misc Data:
[06:10:09]OpenGL Vendor : NVIDIA Corporation
[06:10:09]OpenGL Renderer : GeForce Go 7300/PCI/SSE2
[06:10:09]OpenGL Version : 2.1.2
[06:10:09]OpenGL GLSL Version : 1.20 NVIDIA via Cg compiler
[06:10:09]Video Mode 1280 x 800 (32 bpp) (fullscreen)
[06:10:10]OpenAL Vendor: Creative Labs Inc.
[06:10:10]OpenAL Version: 1.1
[06:10:10]OpenAL Renderer: Software
[06:10:10]OpenAL Extensions: EAX EAX2.0 EAX3.0 EAX4.0 EAX5.0 EAX3.0EMULATED EAX4.0EMULATED AL_EXT_OFFSET AL_EXT_LINEAR_DISTANCE AL_EXT_EXPONENT_DISTANCE
[06:10:10]Using language: System locale
[06:10:11]UPnP device found: http://192.168.1.1:80/Public_UPNP_gatedesc.xml urn:schemas-upnp-org:device:InternetGatewayDevice:1 LAN address 192.168.1.13
[06:33:53]Current Level/map is Sk-TeamWar3-4Players-T1

C:\Program Files\Warzone 2100 2.3b5\warzone2100.exe caused an Access Violation at location 004f440f in module C:\Program Files\Warzone 2100 2.3b5\warzone2100.exe Reading from location 00000040.

Log message: info    |06:39:02: [sendCheck] Couldn't sendDroidCheck()  Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendStructureCheck() Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendPowerCheck() Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendScoreCheck() Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendPing() Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendDroidCheck()  Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendStructureCheck() Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendPowerCheck() Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendScoreCheck() Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendPing() Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendDroidCheck()  Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendStructureCheck() Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendPowerCheck() Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendScoreCheck() Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendPing() Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendDroidCheck()  Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendStructureCheck() Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendPowerCheck() Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendScoreCheck() Sent # 42393, Recv 69534
Log message: info    |06:39:02: [sendCheck] Couldn't sendPing() Sent # 42393, Recv 69534

Registers:
eax=00000000 ebx=08575d28 ecx=00000000 edx=6b0a0001 esi=00000000 edi=00000001
eip=004f440f esp=0022f8f0 ebp=0022f918 iopl=0         nv up ei pl nz na po nc
cs=001b  ss=0023  ds=0023  es=0023  fs=003b  gs=0000             efl=00210206

Call stack:
004F440F  C:\Program Files\Warzone 2100 2.3b5\warzone2100.exe:004F440F  buildBlueprint  /home/co/c/warzone/win32/build/src/../../../src/structure.c:2005
0042A005  C:\Program Files\Warzone 2100 2.3b5\warzone2100.exe:0042A005  T.585  /home/co/c/warzone/win32/build/src/../../../src/display3d.c:1719
0042A5DC  C:\Program Files\Warzone 2100 2.3b5\warzone2100.exe:0042A5DC  draw3DScene  /home/co/c/warzone/win32/build/src/../../../src/display3d.c:641
0042C1A1  C:\Program Files\Warzone 2100 2.3b5\warzone2100.exe:0042C1A1  displayWorld  /home/co/c/warzone/win32/build/src/../../../src/display.c:1411
00480A06  C:\Program Files\Warzone 2100 2.3b5\warzone2100.exe:00480A06  gameLoop  /home/co/c/warzone/win32/build/src/../../../src/loop.c:606
0048328C  C:\Program Files\Warzone 2100 2.3b5\warzone2100.exe:0048328C  SDL_main  /home/co/c/warzone/win32/build/src/../../../src/main.c:671
0059508E  C:\Program Files\Warzone 2100 2.3b5\warzone2100.exe:0059508E
00595144  C:\Program Files\Warzone 2100 2.3b5\warzone2100.exe:00595144
00594AF9  C:\Program Files\Warzone 2100 2.3b5\warzone2100.exe:00594AF9
004010A7  C:\Program Files\Warzone 2100 2.3b5\warzone2100.exe:004010A7  __mingw_CRTStartup  /home/ron/devel/debian/mingw32-runtime/mingw32-runtime-3.13/build_dir/src/mingw-runtime-3.13-20070825-1/crt1.c:237
00401123  C:\Program Files\Warzone 2100 2.3b5\warzone2100.exe:00401123

Issue migrated from trac:1334 at 2022-04-15 20:23:33 -0700

wzdev-ci commented 14 years ago

cybersphinx edited the issue description

wzdev-ci commented 14 years ago

Zarel commented

I nominate "T.585" for "most descriptive function name ever"

wzdev-ci commented 14 years ago

Zarel commented

Hrm. There's really very little we can do about this, especially with the information given.

wzdev-ci commented 14 years ago

cybersphinx commented

I think I've seen this before. And branches/2.3/src/structure.c#L2005 could crash, psStats isn't checked in that function.

wzdev-ci commented 14 years ago

Per uploaded file mitigate1334.diff (1.7 KiB)

Patch to mitigate the crash

wzdev-ci commented 14 years ago

cybersphinx commented

Hm, should prevent this crash. buildBlueprint's return value is always used unchecked though, so if it gets a NULL from somewhere else, the game will crash later.

wzdev-ci commented 14 years ago

cybersphinx commented

Ah, #1259, first attachment, last crash.

wzdev-ci commented 14 years ago

Per changed status from new to closed

wzdev-ci commented 14 years ago

Per set resolution to fixed

wzdev-ci commented 14 years ago

Per commented

(In [9113]) 2.3: Mitigate a crash in blueprint drawing. Also add more debug info when bug happens. Closes #1334

wzdev-ci commented 14 years ago

Per commented

(In [9115]) Mitigate a crash in blueprint drawing. Also add more debug info when bug happens. Closes #1334

wzdev-ci commented 14 years ago

Zarel commented

You'll notice the crash was:

Reading from location 00000040.

i.e. I'm not sure you're checking for the right null pointers.