search

Warzone2100 / old-trac-import

Archived Import of (old) Warzone 2100 Trac
0 stars 0 forks source link

abolish automatic resizing of minimap #4689

Closed wzdev-ci closed 6 years ago

wzdev-ci commented 6 years ago

resolution_fixed type_patch (an actual patch, not a request for one) | by Forgon

This patch series abolishes automatic resizing of the minimap, which is desirable for a configuration option to change the default radar size, to be introduced with #4629.

Radar size ranges from 8 to 64 with a default value of 16 (see './src/radar.h'). A routine that assumed a value < 4 has been removed.

Maps with width < 150 tiles like Sk-Rush no longer start with a resized radar of 14 (if the screen is <= 640 pixels wide) or 32, which will likely be noticed by users (see attached image [raw-attachment:minimap_size_comparison.png]). Almost every single one of the popular 8-player NTW maps is 140 tiles wide and will thus start with a smaller radar size. Among 680 different maps whose size was measured with a bash script (view [raw-attachment:list_map_sizes] for the script and [raw-attachment:map_sizes.csv] for the results), 36% were affected overall.

When rotateRadar was enabled, all minimaps were rescaled as though their larger side (either width or height) was 128 tiles long. A map 143x159 tiles large (the average dimensions of 680 maps examined) would thus appear with a sidelength reduced by about ~ 20%. Note that maps cannot be larger than 256 tiles or smaller than 2 tiles on either side, although tiny maps are rare: the smallest popular multiplayer map, HugeassRebuild, is 21x21 tiles in size and thus appeared with a sidelength about 6-times larger with rotating radar than fixed radar (see attached image [raw-attachment:radar_rotation_enlarging_minimap.png]).

Rotating radar also shifted the center of the minimap so that it fit into a square of its largest sidelength (see attached image [raw-attachment:radar_rotation_centering_minimap.png]). This cost valuable screen space: Out of 680 maps, 45% were higher than wide and would thus move to the left, 14% were wider than high and shifted upwards, while 40% had equal dimensions and thereby unaffected.

Lastly, the radar size in tutorials has also increased since a routine shrinking it was ignored when converting them to JavaScript (ticket #4641) and removed from the game altogether with 76ac44c84b7f89a860c743202bb002586d137e63.

Issue migrated from trac:4689 at 2022-04-16 12:58:32 -0700

wzdev-ci commented 6 years ago

Forgon _uploaded file list_map_sizes (1.3 KiB)_

bash script that finds all maps inside given files and directories and write their names next to their dimensions to the file map_sizes.csv

wzdev-ci commented 6 years ago

Forgon _uploaded file map_sizes.csv (14.8 KiB)_

list of 680 different maps sorted by their width

wzdev-ci commented 6 years ago

Forgon _uploaded file minimap_size_comparison.png (125.8 KiB)_

comparison of radar zoom settings 14, 16 and 32 minimap_size_comparison.png

wzdev-ci commented 6 years ago

Forgon _uploaded file minimap_size_comparison.xcf (318.4 KiB)_

comparison of radar zoom settings 14, 16 and 32 (GIMP file with layers)

wzdev-ci commented 6 years ago

Forgon _uploaded file radar_rotation_centering_minimap.png (141.9 KiB)_

illustration of radar rotation shifting the center of minimaps, with red lines and a dot outlining the squared minimap area and its center radar_rotation_centering_minimap.png

wzdev-ci commented 6 years ago

Forgon _uploaded file radar_rotation_centering_minimap.xcf (647.8 KiB)_

illustration of radar rotation shifting the center of minimaps, with red lines and a dot outlining the squared minimap area and its center (GIMP file with layers)

wzdev-ci commented 6 years ago

Forgon _uploaded file radar_rotation_enlarging_minimap.png (70.6 KiB)_

comparison of radar size with rotateRadar set to true and false for the map HugeassRebuild radar_rotation_enlarging_minimap.png

wzdev-ci commented 6 years ago

Forgon _uploaded file radar_rotation_enlarging_minimap.xcf (172.2 KiB)_

comparison of radar size with rotateRadar set to true and false for the map HugeassRebuild (GIMP file with layers)

wzdev-ci commented 6 years ago

Forgon _uploaded file no_unused_radar_routine.patch (0.7 KiB)_

patch file created with git format-patch (part 1/3)

wzdev-ci commented 6 years ago

Forgon _uploaded file consistent_initial_radar_zoom.patch (0.7 KiB)_

patch file created with git format-patch (part 2/3)

wzdev-ci commented 6 years ago

Forgon _uploaded file abolish_radar_rescaling_and_recentering.patch (2.3 KiB)_

patch file created with git format-patch (part 3/3)

wzdev-ci commented 6 years ago

Forgon2100 forgon2100@... changed status from new to closed

wzdev-ci commented 6 years ago

Forgon2100 forgon2100@... changed owner from ` toForgon2100 forgon2100@gmail.com`

wzdev-ci commented 6 years ago

Forgon2100 forgon2100@... changed resolution from ` tofixed`

wzdev-ci commented 6 years ago

Forgon2100 forgon2100@... committed [0752]

In https://github.com/Warzone2100/warzone2100/commit/0752c2b00e1cd68256ba77e67178a7c0a0fa7a9a:

#CommitTicketReference repository="" revision="0752c2b00e1cd68256ba77e67178a7c0a0fa7a9a"
fixes #4689: remove routine that assumed radar zoom < 4 while the minimum value is 8 (patch 1/3)
wzdev-ci commented 6 years ago

Forgon2100 forgon2100@... commented

In https://github.com/Warzone2100/warzone2100/commit/af9a96f042ce2067ce34f532280e4bb384dcf96c:

#CommitTicketReference repository="" revision="af9a96f042ce2067ce34f532280e4bb384dcf96c"
fixes #4689: maps with width < 150 tiles like Sk-Rush no longer start with radar resized to 14 or 32 based on screen width (patch 2/3)
wzdev-ci commented 6 years ago

Forgon2100 forgon2100@... commented

In https://github.com/Warzone2100/warzone2100/commit/d3410d0b1bd20ebbe8f1910aded3c5cb68402ece:

#CommitTicketReference repository="" revision="d3410d0b1bd20ebbe8f1910aded3c5cb68402ece"
fixes #4689: abolish radar rotation rescaling minimaps to a sidelength of 128 tiles as well as recentering them (patch 3/3)
wzdev-ci commented 6 years ago

Per commented

On sk-rush, the minimap is now a useless, tiny postage stamp. How is this a good thing?

sk-rush is the default map. If it doesn't look good on that map, it is broken.

wzdev-ci commented 6 years ago

Forgon changed _comment0 which not transferred by tractive

wzdev-ci commented 6 years ago

Forgon commented

Replying to Warzone2100/old-trac-import#4689 (comment:4):

On sk-rush, the minimap is now a useless, tiny postage stamp. How is this a good thing?

sk-rush is the default map. If it doesn't look good on that map, it is broken.

This could easily be fixed by increasing the default minimap size from 16 to 32. I would have liked to do that anyway, because I increase radar size immediately at the start of almost every game.

Would you be okay with that change?

wzdev-ci commented 6 years ago

Per commented

Let's try that. We should always aim to have good defaults, since most players never change options.

wzdev-ci commented 6 years ago

Forgon edited the issue description

wzdev-ci commented 6 years ago

Forgon commented

Replying to Warzone2100/old-trac-import#4689 (comment:6):

Let's try that. We should always aim to have good defaults, since most players never change options.

Done, with #4699.