search

Warzone2100 / old-trac-import

Archived Import of (old) Warzone 2100 Trac
0 stars 0 forks source link

Default map: Use already defined const string #4848

Closed wzdev-ci closed 5 years ago

wzdev-ci commented 5 years ago

resolution_fixed type_patch (an actual patch, not a request for one) | by Kreuvf

The const string is already defined in configuration.h, but only used in multiint.cpp. Now it is also used in configuration.cpp making it easier to change the default map.

Issue migrated from trac:4848 at 2022-04-16 13:33:31 -0700

wzdev-ci commented 5 years ago

Kreuvf uploaded file use-define-for-default-map.patch (0.9 KiB)

wzdev-ci commented 5 years ago

Steven Koenig kreuvf@... changed status from new to closed

wzdev-ci commented 5 years ago

Steven Koenig kreuvf@... changed owner from ` toSteven Koenig kreuvf@gna.org`

wzdev-ci commented 5 years ago

Steven Koenig kreuvf@... changed resolution from ` tofixed`

wzdev-ci commented 5 years ago

Steven Koenig kreuvf@... commented

In https://github.com/Warzone2100/warzone2100/commit/db81858f454276e642c36c5c41be001f34823366:

#CommitTicketReference repository="" revision="db81858f454276e642c36c5c41be001f34823366"
Make it easier to change the default map.

Closes ticket 4848.
wzdev-ci commented 5 years ago

Kreuvf changed _comment0 which not transferred by tractive

wzdev-ci commented 5 years ago

Kreuvf commented

There is one caveat with this. When you choose a default map you must make sure that in lines 146, 349 and 368 game.maxPlayers is set to the corresponding number of players. I am confident that there is already a way to get maxPlayers of map so that this could be improved easily. I am still trying to figure out what exactly has to be done to get the number of player slots correct.

wzdev-ci commented 5 years ago

Kreuvf commented

See #4849 for fixing this bug.