Warzone2100 / warzone2100

Command the forces of The Project in a battle to rebuild the world after mankind has been nearly destroyed by nuclear missiles. A 100% free and open source real-time strategy game for Windows, macOS, Linux, BSD+
https://wz2100.net
GNU General Public License v2.0
3.24k stars 534 forks source link

Build failure in ivis_opengl (vk::DispatchLoaderDynamic → vk::detail::DispatchLoaderDynamic) #4121

Closed AMDmi3 closed 3 weeks ago

AMDmi3 commented 3 weeks ago

Describe the bug

Similar build error in many files under lib/ivis_opengl:

/work/usr/ports/games/warzone2100/work/warzone2100/lib/ivis_opengl/3rdparty/vkh_info.hpp:61:112: error: no type named 'DispatchLoaderDynamic' in namespace 'vk'; did you mean 'vk::detail::DispatchLoaderDynamic'?
   61 |         void Output_SurfaceInformation(const vk::PhysicalDevice& physicalDevice, const vk::SurfaceKHR& surface, const vk::DispatchLoaderDynamic& vkDynLoader);
      |                                                                                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                                                                       vk::detail::DispatchLoaderDynamic
/usr/local/include/vulkan/vulkan.hpp:17275:11: note: 'vk::detail::DispatchLoaderDynamic' declared here

The build is fixed after bulk replacing vk::DispatchLoaderDynamic with vk::detail::DispatchLoaderDynamic.

Your System:

Monsterovich commented 3 weeks ago

Which version of Vulkan SDK do you have?

AMDmi3 commented 3 weeks ago
  • Vulkan: 1.3.301
past-due commented 3 weeks ago

@AMDmi3 Please let me know if the following PR / patch fixes this for you: https://github.com/Warzone2100/warzone2100/pull/4122

AMDmi3 commented 3 weeks ago

@past-due confirmed, it fixes the build

past-due commented 3 weeks ago

Thank you for the report - we’ve merged that fix for the next release.