search

Wattpad / kube-sqs-autoscaler

Kubernetes pod autoscaler based on queue size in AWS SQS
MIT License
66 stars 15 forks source link

Expected conditions logged as error #11

Closed renatomariscal closed 5 years ago

renatomariscal commented 6 years ago

Hi,

I see a bunch of these in my logs:

level=error msg="Failed scaling down: Min pods reached"

Which is an expected situation, right? So why is it logged as error? I believe just info would be accurate.

I had issues recently that are real errors, so I would like to configure my metric system to create alerts for any error. But it is not doable while we get errors in regular scenarios.

Thanks!

stafot commented 6 years ago

Agree that this should be info not error

renatomariscal commented 6 years ago

https://github.com/Wattpad/kube-sqs-autoscaler/pull/8 seems to fix it

stafot commented 6 years ago

@renatomariscal let's pray to merge it. Or use a fork and merge it :)

renatomariscal commented 5 years ago

As neither this nor the PR has gotten attention in a year, I am assuming this repo is abandoned, and I will be working permanently from a fork. 🤷‍♂