WayfireWM / wayfire-plugins-extra

Additional plugins for Wayfire
MIT License
69 stars 29 forks source link

Plug-in to show touch positions #261

Open zougloub opened 4 weeks ago

zougloub commented 4 weeks ago

It would be nice to have a plugin that can show touch positions on screen, to help with accessibility, or debug touchscreens.

It seems there's a crosshair plug-in in wayfire-plugins-extra that can show mouse pointer position, the idea would be to have something analogue for touchscreen devices.

zougloub commented 3 weeks ago

@soreau is implementing a showtouch plugin in https://github.com/WayfireWM/wayfire-plugins-extra.

We may move this issue there.

I tested the current status, where the showtouch plugin should also work in multi-display situations, and there's one bug : if I press on 2 screens at the same time, the purple dot is appearing only once, which I consider OK because I see this plugin as a debugging tool, but it's position doesn't respect the screen position, eg. in my case, if I put one finger on the right edge of the left screen, and one finger on the left edge of the right screen, the purple dot is at the right edge of the right screen, when it should be between the fingers.

soreau commented 3 weeks ago

@soreau is implementing a showtouch plugin in https://github.com/WayfireWM/wayfire-plugins-extra.

We may move this issue there.

I tested the current status, where the showtouch plugin should also work in multi-display situations, and there's one bug : if I press on 2 screens at the same time, the purple dot is appearing only once, which I consider OK because I see this plugin as a debugging tool, but it's position doesn't respect the screen position, eg. in my case, if I put one finger on the right edge of the left screen, and one finger on the left edge of the right screen, the purple dot is at the right edge of the right screen, when it should be between the fingers.

I'm guessing this problem probably stems from the fact that the output layout is reversed in the config and there is some bug. For reference, the calculation for the center point of all fingers is handled by wf-touch here.

soreau commented 3 weeks ago

I tested this with stipc using a virtual touch device and the only way I can reproduce this is if the outputs are actually swapped and not swapped in config (or vice versa, the outputs are swapped in config but not physically). So maybe you're testing with a minimal config and do not have the output position layout configured or have inadvertently physically swapped the outputs?

soreau commented 3 weeks ago

To be clear, the showtouch plugin is in the showtouch branch of wayfire-plugins-extra.

zougloub commented 3 weeks ago

I tested this with stipc using a virtual touch device and the only way I can reproduce this is if the outputs are actually swapped and not swapped in config (or vice versa, the outputs are swapped in config but not physically). So maybe you're testing with a minimal config and do not have the output position layout configured or have inadvertently physically swapped the outputs?

:man_facepalming: I had swapped the monitors by mistake during transportation. Everything is OK.