search

WearBlackAllDay / DimensionalThreading

An attempt to optimize the fabric server, by assigning each dimension their own thread.
MIT License
255 stars 22 forks source link

Conflict with Dispenser Configurator #44

Closed supersaiyansubtlety closed 2 years ago

supersaiyansubtlety commented 2 years ago

I'm the dev of Dispenser Configurator, and I just noticed that if you install this mod and DC, activating a dispenser (tested with a sapling in it, which DC adds behavior for) causes the server to freeze.

Unfortunately I was unable to get Dimensional Threading into my dev environment using jitpack (modImplementation "com.github.WearBlackAllDay:DimensionalThreading:v1.2.5"), and the game freezes without crashing or outputting anything into the log. This means there's not much I can do on my end.

WearBlackAllDay commented 2 years ago

you can simply drag the DimThread jar into /run/mods if you want to use it from ide

also you should probably not store a World reference statically https://gitlab.com/supersaiyansubtlety/dispenser_configurator/-/blob/master/src/main/java/net/sssubtlety/dispenser_configurator/DispenserConfiguratorInit.java

Im aware of DimThreads struggles with datapacks in general and will get around to fixing that sometime.

supersaiyansubtlety commented 2 years ago

Removing the static world reference fixed it, thanks for the tip.