[Bug] "Who we are" section in "About" is not showing up in mobile view

cherylli commented 1 year ago

What do we need to build or fix? In mobile view (live and dev), "who we are" section is not showing up. Desktop version is fine. I have tried this on my phone and PC browser (chrome and edge). The issue happens on PC is not 100% but it's 100% on my phone (chrome, firefox)

Is anyone else experiencing this?

Technical details Scrolling down the page https://www.webdevpath.co/about

Approach suggestions No suggestion yet, I would like to confirm if anyone else getting this

Deadline N/A

Acceptance criteria

Test the section and components in many screen sizes, you can use the Inspect tool for that.
Please test if the new changes added to the components do not affect the other instances.
Test the feature in many browsers, such as Chrome, Firefox, Edge, and Safari (MAC).
If there are any build problems when submitting your PR, run yarn build locally to solve the issues and commit the changes.
Update the CHANGELOG.md file.

Satoshi-Sh commented 1 year ago

Interesting. I got the same bug on mobile. When I opened the About page with a desktop browser with shorter width, the profiles didn't get displayed as well. It has something to do with the window width.

I will let you know if I find the cause of this bug.

Satoshi-Sh commented 1 year ago

Animation making opacity 0 -> 1 isn't working because of customClass='primary__accent'. If I remove it, it works fine with the smaller width window, but the background color is white now.

cherylli commented 1 year ago

Thanks for checking. I think it might be related to the styled-components conversion as it was definitely working before that. Maybe the mobile styles weren't ported properly.

Satoshi-Sh commented 1 year ago

I'm not sure why this issue wasn't closed when I merged the branch. https://github.com/Web-Dev-Path/web-dev-path/pull/191

I will close this issue.

mariana-caldas commented 1 year ago

I'm not sure why this issue wasn't closed when I merged the branch. #191

I will close this issue.

Hey @Satoshi-Sh !

That happened because we forgot to connect the issue with the PR. That's totally fine to close issues manually tough, good catch!

Screen Shot 2023-08-24 at 9 41 47 AM

Satoshi-Sh commented 1 year ago

I thought putting the issue number in the pull request description takes care of linking. Now I know how to link the issue. Thanks, Mariana!!

Web-Dev-Path / web-dev-path

[Bug] "Who we are" section in "About" is not showing up in mobile view #189