search

WebAssembly / tool-conventions

Conventions supporting interoperatibility between tools working with WebAssembly.
Artistic License 2.0
297 stars 65 forks source link

Fix CodeMetadata encoding definition for trace_inst #182

Closed jabraham17 closed 2 years ago

jabraham17 commented 2 years ago

Change size from a fixed value of 0x4 to a variable unsigned integer.

dschuff commented 2 years ago

I just ran across this again, sorry I missed it the first time around. Is it still relevant? what's the reason for it?

jabraham17 commented 2 years ago

This is still relevant. Having a variable sized integer is the correct implementation. As I was implementing this convention, I was reviewing this and came across the mistake.