Fix bug in wasm2c's tail call optimization codegen

WebAssembly / wabt

The WebAssembly Binary Toolkit

Apache License 2.0

6.91k stars 702 forks source link

Fix bug in wasm2c's tail call optimization codegen #2491

Open squk opened 1 month ago

squk commented 1 month ago

The default wasm-rt implementation defines wasm_rt_memcpy as memcpy which expects void*

keithw commented 1 month ago

I'm a little confused -- we pass the tail-call tests, so... this suggests we need some additional testing here. How is this code-path not hit by the current tests?

keithw commented 3 weeks ago

I guess there are no spec tests for tail-calls that use multi-value? If so that seems like an omission we should fix. @squk , are you up for either:

adding a test to this repo (of using tail-call with multi-value) that this PR will make green, and/or
submitting one upstream to the tail-call proposal repo?

If you don't have cycles for this or don't want to, I think we could probably take it from here too, but I'd love to have a test somewhere.