search

WebFreak001 / code-debug

Native debugging for VSCode
The Unlicense
409 stars 115 forks source link

Add support for ssh algorithms, compaitibale with old embedded devices #411

Open xiaoyun94 opened 9 months ago

xiaoyun94 commented 9 months ago

Add support for ssh algorithms, compaitibale with old embeded devices

GitMensch commented 9 months ago

Sounds good - can you please add something to the readme for this setting? Should we also update SSH2 along? This seems to add optional strict key support.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (26d7d9f) 21.30% compared to head (00a5990) 20.53%. Report is 8 commits behind head on master.

Files Patch % Lines
src/backend/mi2/mi2.ts 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #411 +/- ## ========================================== - Coverage 21.30% 20.53% -0.77% ========================================== Files 14 14 Lines 1737 1802 +65 Branches 375 389 +14 ========================================== Hits 370 370 - Misses 1322 1387 +65 Partials 45 45 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xiaoyun94 commented 9 months ago

Sounds good - can you please add something to the readme for this setting? Should we also update SSH2 along? This seems to add optional strict key support.

Sounds good - can you please add something to the readme for this setting? Should we also update SSH2 along? This seems to add optional strict key support.

These parameters i choosed are listed in README.md of mscdex/ssh

xiaoyun94 commented 9 months ago

LGTM.

Do you want to add your change to the CHANGELOG (possibly along with further REAMDE adjustments) or should I pull and do another commit?

I suggest you do that. I am not good at English writing😂

xiaoyun94 commented 9 months ago

@GitMensch what should i do next

GitMensch commented 3 months ago

Can you try to update to ssh2 1.15 and retest connecting to your old embedded device please?

GitMensch commented 2 months ago

For the ChangeLog you can use

-add support for ssh algorithms, compatible with old embedded devices ([@xiaoyun94])

and for the first PR add your entry below "" as well, please.

xiaoyun94 commented 2 months ago

Can you try to update to ssh2 1.15 and retest connecting to your old embedded device please?

no device available recently, so sorry