mi2: Follow tsc type recommendations for some parameters

WebFreak001 / code-debug

Native debugging for VSCode

The Unlicense

409 stars 115 forks source link

mi2: Follow tsc type recommendations for some parameters #434

Closed dd86k closed 3 months ago

dd86k commented 3 months ago

Since tsc was emitting errors, I decided to apply the suggestions to mi2.ts to (try to) help understand the intent of the code and make the PR. (I know, lazy PR, and didn't check for other PRs).

Without this patch, I cannot launch the addon for debugging.

Open to comments/suggestions/edits/rejection.

EDIT: Added reason, removed some cruft.

GitMensch commented 3 months ago

Thank you for your contribution; the changes are already part of master so I'm closing that - but the MiNode part is actually only in because of your PR...