search

WebPlatformForEmbedded / libwpe

General-purpose library specifically developed for the WPE-flavored port of WebKit.
BSD 2-Clause "Simplified" License
49 stars 36 forks source link

fix: allow resetting fullscreen client to nullptr #129

Closed yury-s closed 1 year ago

yury-s commented 1 year ago

To avoid crashes like https://bugs.webkit.org/show_bug.cgi?id=264360 we need to reset wpe backend clients (see this PR) and the assert in wpe_view_backend_set_fullscreen_clientdid not allow that.

mcatanzaro commented 1 year ago

Can you squash your changes into one commit please?

yury-s commented 1 year ago

Can you squash your changes into one commit please?

Done. We usually rely on GitHub doing it, which is why I just pushed one on top.

mcatanzaro commented 1 year ago

Looks good now, but I'm not a maintainer so can't merge.