search

WebTheoryLLC / omniauth-twitch

OmniAuth Strategy for Twitch
MIT License
32 stars 22 forks source link

Made adjustment to make scopes operate as expected. #14

Closed rigel-eva closed 3 years ago

rigel-eva commented 6 years ago

Also updated the site, authorize url, and token url parameters to futureproof the gem going forward.

This fixes the issue I posted about earlier, Issue 13 - Adding New scopes results in error

jcgertig commented 6 years ago

I cant look at this today so the earliest will be the morning.

On Tue, Jun 19, 2018, 5:43 PM Hound notifications@github.com wrote:

@houndci-bot commented on this pull request.

In lib/omniauth/twitch/version.rb https://github.com/WebTheoryLLC/omniauth-twitch/pull/14#discussion_r196601537 :

@@ -1,5 +1,5 @@ module OmniAuth module Twitch

  • VERSION = "0.2.0"
  • VERSION = "0.3.0"

Style/MutableConstant: Freeze mutable objects assigned to constants.

In lib/omniauth/strategies/twitch.rb https://github.com/WebTheoryLLC/omniauth-twitch/pull/14#discussion_r196601538 :

@@ -21,7 +21,9 @@ class Twitch < OmniAuth::Strategies::OAuth2 option :authorize_options, [:scope]

   uid{ raw_info['_id'] }

-

  • def request_phase
  • redirect client.auth_code.authorize_url({:redirect_uri => callback_url}.merge(authorize_params)).gsub(/%2[b,B]/,'+')

Layout/SpaceInsideHashLiteralBraces: Space inside { missing. Style/HashSyntax: Use the new Ruby 1.9 hash syntax. Layout/SpaceInsideHashLiteralBraces: Space inside } missing. Metrics/LineLength: Line is too long. [124/80] Layout/SpaceAfterComma: Space missing after comma. Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

In lib/omniauth/strategies/twitch.rb https://github.com/WebTheoryLLC/omniauth-twitch/pull/14#discussion_r196601539 :

@@ -8,9 +8,9 @@ class Twitch < OmniAuth::Strategies::OAuth2 option :name, "twitch"

   option :client_options, {

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

In lib/omniauth/strategies/twitch.rb https://github.com/WebTheoryLLC/omniauth-twitch/pull/14#discussion_r196601540 :

@@ -8,9 +8,9 @@ class Twitch < OmniAuth::Strategies::OAuth2 option :name, "twitch"

   option :client_options, {

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/WebTheoryLLC/omniauth-twitch/pull/14#pullrequestreview-130186809, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbyu17mzjgSvoBGk2J1KaOE0jn0_mtUks5t-X6jgaJpZM4UuWY6 .

rigel-eva commented 6 years ago

Fair enough, thank you for your prompt response!

jcgertig commented 6 years ago

@rigel-eva does this still do what you want?

krtschmr commented 4 years ago

when is this getting merged?