Add image in docker-compose file in README.rst

WeblateOrg / docker-compose

Docker compose for Weblate

https://docs.weblate.org/en/latest/admin/deployments.html#docker

GNU General Public License v3.0

77 stars 64 forks source link

Add image in docker-compose file in README.rst #124

Closed jmc-av-market closed 2 years ago

jmc-av-market commented 2 years ago

Proposed changes

Add missing configuration in docker-compose file.

Checklist

[X] Lint and unit tests pass locally with my changes.
[X] I have added tests that prove my fix is effective or that my feature works.
[X] I have added documentation to describe my feature.
[X] I have squashed my commits into logic units.
[X] I have described the changes in the commit messages.

Other information

nijel commented 2 years ago

This is override file, so the image is not necessary here...

jmc-av-market commented 2 years ago

This is override file, so the image is not necessary here...

If you don't specify the image, getting started doesn't work and you will get this error. Hence the modification only in the readme. If you still don't agree, we can close this pull request.

docker-compose up -d
ERROR: The Compose file is invalid because:
Service weblate has neither an image nor a build context specified. At least one must be provided.

nijel commented 2 years ago

The docker-compose.yml is here: https://github.com/WeblateOrg/docker-compose/blob/main/docker-compose.yml, with the override, you only specify what you want to change. I've clarified the README in 82240498b4ecad9e7fd7801615312953dbda39b6