Move source-code fonts to new build workflow - Githubissues

WeblateOrg / weblate

Web based localization tool with tight version control integration.

https://weblate.org/

GNU General Public License v3.0

4.65k stars 1.02k forks source link

Move source-code fonts to new build workflow #13093

Open meel-hd opened 1 week ago

meel-hd commented 1 week ago

Proposed changes

Moved source-code fonts to new build workflow

Changes Include:

Removed the old scripts/yarn/**dir, as it is no longer needed.
Moved source-code-pro and source-sans to client/
Built and bundled the fonts.
Updated templates to use the new built fonts and styles.
Added new built bundles license info in REUSE.toml.

Note:

The old bundles did not get removed to keep this PR simple for review.

TODO:

Remove old fonts bundles.
Update any dependents on them to use the new bundles.
if FONTS_CDN_URL is configured it should be seted up with static/js/vendor/fonts instead of the old font-source/
Remove the old yarn-update script and its configs and workflows

Related: #12172

Checklist

[ ] Lint and unit tests pass locally with my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added documentation to describe my feature.
[ ] I have squashed my commits into logic units.
[x] I have described the changes in the commit messages.

Other information

meel-hd commented 3 days ago

@nijel I rerun the test suite on main (without the new changes) and it seems they fail also in there, I'm not sure what to do next.

summary

weblate/trans/tests/test_selenium.py::SeleniumTests::test_add_component missing element #list-add-button weblate/trans/tests/test_selenium.py::SeleniumTests::test_fonts missing element #upload_font_submit weblate/trans/tests/test_selenium.py::SeleniumTests::test_login missing element #dashboard-return weblate/trans/tests/test_selenium.py::SeleniumTests::test_screenshots missing element #query-dropdown weblate/trans/tests/test_selenium.py::SeleniumTests::test_weblate