search

WeebDev / Commando

[DEPRECATED] âš« Commando Discord bot built on discord.js-commando.
https://github.com/Gawdl3y/discord.js-commando
MIT License
77 stars 63 forks source link

Interest isn't applied to bank's money #38

Closed Slamakans closed 7 years ago

Slamakans commented 7 years ago

Image

It's applied to users' accounts though.

Idk if it's intended or nah, but if it's like this, wouldn't the bank go negative if people withdrew all their money?

Is that how banks work :thinking:💭? If it is, then I get why the world went to shit a few years back and a few years before that and a few years before that and a few ...

iCrawl commented 7 years ago

@Programmix might have a look at this, since he wrote the initial code for it.

aemino commented 7 years ago

Um that's not really how interest works. Interest is only applied to the money in the bank; the ledger.

Slamakans commented 7 years ago

@Programmix It adds money to the bank balance you see when you do ?donuts, but not to the total amount of donuts in the bank.

Say I'm the only user. I deposit 1000 donuts. The interest rate is 0.1%. The interest is applied. I do ?donuts, it shows 1010 donuts. I do ?bank, it says the bank has 1000 donuts in it.

Is that how it's supposed to be?

aemino commented 7 years ago

Yes, yes it is.

Slamakans commented 7 years ago

So does the interest go negative when the bank has negative donuts?

aemino commented 7 years ago

When would the bank have negative donuts?

Slamakans commented 7 years ago

... when you withdraw the 1010 donuts when the bank only has 1000, maybe?

aemino commented 7 years ago

Check the code, that can't happen. Just like in real life, the bank won't let you withdraw more money than the bank has.

kurisubrooks commented 7 years ago

If it's a credit account, you can withdraw more than you have, but you need to pay it back otherwise dire consequences.

iCrawl commented 7 years ago

Credit accounts or loans arent a thing yet iirc, @Programmix planned on doing it, but so far its not implemented yet, so I don't see it happening.

Slamakans commented 7 years ago

@Programmix So you're saying the bank is supposed to have a lot less donuts in it than the sum of all bank accounts' balances, with the difference increasing every time interest is applied?

aemino commented 7 years ago

Yes... that's how banks in real life work. However, it isn't "supposed to" have a lot less donuts. Right now the bank has just as many donuts as the total balance of everyone.

ickerio commented 7 years ago

We just got to a point on the server where most people had "money in the bank", none "in hand" but the bank itself was dry. The bank needs a way to make money or the whole Commando economy won't really work.

Buluphont commented 7 years ago

That is how banks work. If every person makes a run on a bank and withdraws all their money, banks get fucked. This is what happened during the Great Depression, and the reason we have the FDIC. Your bank shouldn't be applying interest to its own money, because then it'd be actually printing money, lol. What they actually do is invest the money and use the profit from returns on investments to keep the operation going and profits flowing.

On Mar 29, 2017 04:04, "rbJARB" notifications@github.com wrote:

We just got to a point on the server where most people had "money in the bank", none "in hand" but the bank itself was dry. The bank needs a way to make money or the whole Commando economy won't really work.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/WeebDev/Commando/issues/38#issuecomment-290056927, or mute the thread https://github.com/notifications/unsubscribe-auth/AL4Bc95Hmj61dwj_7HW1cfCKuEhdERLoks5rqjqjgaJpZM4LynuP .

ickerio commented 7 years ago

Yes, I know what they do to earn money, but they don't do it here. So is there anyway for it to earn money?

On Wed, Mar 29, 2017 at 10:03 PM, Buluphont notifications@github.com wrote:

That is how banks work. If every person makes a run on a bank and withdraws all their money, banks get fucked. This is what happened during the Great Depression, and the reason we have the FDIC. Your bank shouldn't be applying interest to its own money, because then it'd be actually printing money, lol. What they actually do is invest the money and use the profit from returns on investments to keep the operation going and profits flowing.

On Mar 29, 2017 04:04, "rbJARB" notifications@github.com wrote:

We just got to a point on the server where most people had "money in the bank", none "in hand" but the bank itself was dry. The bank needs a way to make money or the whole Commando economy won't really work.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/WeebDev/Commando/issues/38#issuecomment-290056927, or mute the thread https://github.com/notifications/unsubscribe-auth/AL4Bc95Hmj61dwj_ 7HW1cfCKuEhdERLoks5rqjqjgaJpZM4LynuP .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/WeebDev/Commando/issues/38#issuecomment-290099812, or mute the thread https://github.com/notifications/unsubscribe-auth/AN3igqYZN5xJUv71yuXU8u6QJitUn7I3ks5rqmS6gaJpZM4LynuP .

-- Thanks! Harry

iCrawl commented 7 years ago

Yes, there are plans for banks to invest into virtual stocks or whatever, to keep the profits flowing.

Mind you, all of this is still in a very early stage, but we released it anyway to get some kind of feeling what to do next.