search

Whiteknight / mediawiki-embedvideo

Flash video embedding extension for MediaWiki
http://whiteknight.github.com
Other
23 stars 54 forks source link

Add support for HTTPS selectively to supported services #39

Open TomMettam opened 10 years ago

TomMettam commented 10 years ago

I believe this is the best solution for https support.

We only use https when required, and only for supported services.

Reason: Newer browsers block embedded insecure content when requested from a secure page. However, most of these services do not yet support SSL, so if we blanket change them all to //, it will break compatibility in older browsers.

ttguy commented 9 years ago

Ok. I have been trawling through pull requests to to with HTTPS and as I have mentioned on other ones. We need a fix for this issue. eg Recently userbase.kde.org changed the wiki to make SSL manditory accross the site. And this broke youtube embeds in modern browsers because the page was delivering mixed content and the browser blocked the insecure YT content - leaving a blank space on the page. So you should allow prasad83s fix or something like it to fix this issue. userbase.kde.org hacked a fix into EmbedVideo.Services.php to get around this issue but it should work out of the box. So I vote that we go with this one. Not that a vote from a neophyte like me means much. But just my 2 cents worth.