WhoCraft / TardisRefined

A Minecraft mod for Forge and Fabric which brings the TARDIS from Doctor Who to Minecraft.
Other
58 stars 24 forks source link

Prevent Auto Jump making you miss the immersive portal #187

Closed leafreynolds closed 9 months ago

leafreynolds commented 9 months ago

Minecraft has a default config setting that will auto-jump the player when nearing a block that they can jump on top of.

This means that when the player is walking towards a Tardis, they will auto jump, landing on top of the collision box (or skipping past the tardis) and miss the immersive portal completely.

Contained commit raises the height of the Tardis block's collision, preventing auto jump from triggering. Does not affect the briefcase shell, as that uses an override specifically for that shell shape.

Jeryn99 commented 9 months ago

Tested with Immersive Portals?

leafreynolds commented 9 months ago

yes, as this is specifically fixing a thing for immersive portals (I can tell you didn't read the description fully :P)

The non immersive portals version doesn't need it quite as much (but is still helpful) as it triggers moving the player via touching the door collision area at all.

Jeryn99 commented 9 months ago

Ah, whoops, I read it inverted somehow, happy to merge