search

Winetricks / winetricks

Winetricks is an easy way to work around problems in Wine
GNU Lesser General Public License v2.1
2.83k stars 407 forks source link

Winetricks' comctl32 v5 causes crashes in latest Wine releases #824

Closed kevgrig closed 7 years ago

kevgrig commented 7 years ago

Please see https://bugs.winehq.org/show_bug.cgi?id=43486 and comment 9 from shell32 maintainer Nikolay Sivov:

In current wine shell32 depends on comctl32 v6 exports/imagelist behavior. Winetricks install v5 module, and that breaks shell32. [...]

austin987 commented 7 years ago

Yeah, that's not something I can do much about. Native DLLs can help or hurt.

Do you have a suggestion on how winetricks could improve?

kevgrig commented 7 years ago

I wonder if comctl32 v6 might help? I'm not sure where to find that.

austin987 commented 7 years ago

It's in win7sp1. It may be a bit tricky though because of the manifest requirements. It would be more helpful if I could reproduce it.

I looked at the bug, I have some comments from your original report: (In reply to averageradical from comment #0)

I installed Winamp with:

$ wget https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks $ chmod +x winetricks

There's no need to chmod it if you're invoking it with sh, fyi.

$ WINEARCH='win32' sh winetricks comctl32 wininet ie6 allfonts allfonts wmp9 d3dx9_36

FYI, you have allfonts listed twice.

$ wget http://winampplugins.co.uk/Winamp/winamp5666_full_en-us_redux.exe

That redirects to https://getwinamp.com/, which is a webpage saying that it was removed. There's a copy at http://www.meggamusic.co.uk/winamp/, sha256 is 5158d1e92fe476227e9bc739cd15fff4e9e847d8598613a6ae220ce085e3a6fb. Is that correct? Could you upload a screenshot with the menu you're clicking pointed out (I never used winamp much myself).

kevgrig commented 7 years ago

Thanks for taking a look! Since that bug report, I found that winetricks itself can install winamp, so now I've been using the following instructions:

WINEARCH=win32 ./winetricks -q comctl32 directmusic directplay directx9 ie8 mfc42 wmp10 windowmanagerdecorated=n && WINEARCH=win32 ./winetricks winamp

Then on the first execution of Winamp, choose the "Classic Skin". When Winamp launches, there should be a playlist editor at the bottom. Click on the "Add" button in the bottom left and then click on "Add File":

winamp_add_file

There's no need to chmod it if you're invoking it with sh, fyi.

Good point, thanks.

FYI, you have allfonts listed twice.

Yeah, I noticed that too after I submitted! Embarrassing. What is it that causes proofreading to only succeed after I've submitted something for all eternity?!

I never used winamp much myself

You are missing out, my friend. It's the only reason I use Wine. A few tips: Click Alt+L to open the Media Library and add files there, and also double click on the Equalizer in the main play window (under the time display) to open the majestic Milk Drop visualization engine. Note that I make the following additional customizations to Winamp: