Fix Galaxypedia API endpoint returning incorrect ship cost information

Wingysam / Galaxy-Info-v2

Galaxy Info is the all-in-one solution to gathering and accessing information about Galaxy.

https://info.galaxy.casa

3 stars 2 forks source link

Fix Galaxypedia API endpoint returning incorrect ship cost information #14

Closed cswimr closed 10 months ago

cswimr commented 10 months ago

cloudflare-workers-and-pages[bot] commented 10 months ago

Deploying with Cloudflare Pages

Latest commit:	`17cf4be`
Status:	✅ Deploy successful!
Preview URL:	https://506a617e.galaxy-info-v2.pages.dev
Branch Preview URL:	https://gpedia-api-fix.galaxy-info-v2.pages.dev

View logs

Wingysam commented 10 months ago

Why shouldn't the Galaxypedia endpoint return ExtraMaterials?

cswimr commented 10 months ago

Only Ketchupbot uses the Galaxypedia endpoint, so nothing is broken by removing this. Also, the functionality is broken (see screenshot in original post)/

Wingysam commented 10 months ago

Wouldn't Ketchupbot be broken by removing its datasource? Why shouldn't the bot update the ExtraMaterials requirements? Isn't up-to-date ExtraMaterials data in the database?

cswimr commented 10 months ago

sugondese has stated already that ketchupbot isn't broken by this change. This issue would also be fixed if extramaterials were accurate, but they don't appear to be?

cswimr commented 10 months ago

update: its not broken, someone gave annihilator extramaterials for some reason??