search

WinterWolfSV / Cobblemon_Quests

Other
0 stars 1 forks source link

[Crash] Occasional Crashes #5

Closed jmadarg closed 7 months ago

jmadarg commented 7 months ago

On a BigChadGuys+ server there are occasional crashes.

We still don't know what triggers them, but they are becoming more frequent.

This is the crash report https://mclo.gs/s7mQ0cr

java.lang.NullPointerException: Cannot invoke "dev.ftb.mods.ftbquests.quest.ServerQuestFile.getOrCreateTeamData(dev.ftb.mods.ftbteams.api.Team)" because "dev.ftb.mods.ftbquests.quest.ServerQuestFile.INSTANCE" is null

WinterWolfSV commented 7 months ago

Hello! I apologise for the inconvenience. I believe to know the root of the issue and will work on a fix as soon as I'm back home. This means that I'll hopefully have a working release within the next two weeks. Do you by chance know in what situations this error occurrs? Is it when a normal player catches a pokemon or is it another mod that emulates a catch?

jmadarg commented 7 months ago

Sorry for the delay. The issue happens in a cluster of servers for BCG+ (4 servers with nearly 20 players reached regularly), but no player has come out saying it crashed when they catch a Pokemon, but it is probably because they think the crash is a coincidence. It's hard to actually know to be honest

WinterWolfSV commented 7 months ago

Hey! Sorry for not responding earlier, I've been chasing a connection over the past few days. What you mentioned would also explain why the crash happened, if there is no player to get the quest information from. If there is anyone on your team who knows how to program, and you don't want to wait ~1,5 weeks for me to fix it, you could pull the 1.1.7 version from commit 6cc0d1a and inside the eventhandler class, surround all methods in try catches. This should prevent the server from crashing when this error occurs. This would also not require the mod to be changed on the client. Pulling from a later commit would require all players to update to 1.1.8 which has an incompatibility with the cobblebreeding mod. If this is not an option, I'll get a working release up and running when I'm back home.

WinterWolfSV commented 7 months ago

Hey again! The latest release now addresses the issue, it's up on modrinth and curseforge under the version 1.1.9.