Consider using Node-API - Githubissues

Winterreisender / webview-nodejs

A Node.js binding to webview

Apache License 2.0

89 stars 10 forks source link

Consider using Node-API #6

Closed Winterreisender closed 1 year ago

Winterreisender commented 1 year ago

Currently we are using ffi-napi as our way to call C++ code from Node.js, It has pros and cons:

Pros:

Clean and tidy code base
Easy to use

Cons:

Not maintained activately
A little large in size
License issue in FOSSA

We may consider using Node-API(NAPI), the official way to call C++ code.

Pros:

Official
Smaller size
Can use swig interface from webview

Cons:

Difficult to build (has cmake.js and gyp, but we're using xmake)
Difficult to distribute

Make a decision:

[ ] Migrate to NAPI
[x] Not now

Winterreisender commented 1 year ago

Not now. We'll follow the way of webview_deno.