WireCell / wire-cell-toolkit

Toolkit for Liquid Argon TPC Simulation and Reconstruction
https://wirecell.github.io/
Other
7 stars 22 forks source link

fix threshold related bugs #280

Closed HaiwangYu closed 8 months ago

HaiwangYu commented 8 months ago

Some are not bugs. But some are. Simple note attached. May need a better one. 2024-03-12_threshold.pdf

brettviren commented 8 months ago

Note, the test added for #220 checks for this regression of adding back thresholds.

Here is it running on the merge of mine any your apply-pointcloud branch.

❯ bats test/test/test-issue220.bats
test-issue220.bats
 ✗ no wiener_threshold_tag in cfg
   tags: issue:220
   (in test file test/test/test-issue220.bats, line 16)
     `[[ -z "$found" ]]' failed
   found with wiener_threshold_tag:
   /home/bviren/dev/wct/imaging/toolkit/cfg/pgrapher/experiment/icarus/sp.jsonnet:      wiener_threshold_tag: 'threshold%d' % anode.data.ident,
 ✗ no threshold tags in cfg - this fails until wclsFrameSaver issue resolved
   tags: issue:220
   (in test file test/test/test-issue220.bats, line 26)
     `[[ -z "$found1" ]]' failed
   found with 'threshold' tags:
   /home/bviren/dev/wct/imaging/toolkit/cfg/pgrapher/experiment/icarus/wcls-sim-drift-simchannel.jsonnet:  sp_thresholds: wcls.output.thresholds(name='spthresholds', tags=['threshold']),
   /home/bviren/dev/wct/imaging/toolkit/cfg/pgrapher/experiment/icarus/wcls-multitpc-sim-drift-simchannel-omit-noise.jsonnet:  sp_thresholds: wcls.output.thresholds(name='spthresholds', tags=['threshold']),
   /home/bviren/dev/wct/imaging/toolkit/cfg/pgrapher/experiment/icarus/wcls-multitpc-sim-drift-simchannel.jsonnet:  sp_thresholds: wcls.output.thresholds(name='spthresholds', tags=['threshold']),

2 tests, 2 failures