search

Wirena / clang-format-configurator-v2

Interactive clang-format configuration tool
https://clang-format-configurator.site/
MIT License
83 stars 3 forks source link

Impossible to enter string list values. #14

Closed sergio-nsk closed 1 year ago

sergio-nsk commented 1 year ago

image How to enter string list items? The first button adds another button that can only be deleted.

Wirena commented 1 year ago

Grey plus button creates an empty array, which overrides BasedOnStyle default array. Thats what happened on your screenshot Blue plus button appends new element to the array, result looks like this: image

sergio-nsk commented 1 year ago

@Wirena It does not for me. X is not red and there are no input fields are above X.

Wirena commented 1 year ago

@Wirena It does not for me. X is not red and there are no input fields are above X.

Which clang-format version is set?

sergio-nsk commented 1 year ago

I don set it, just open https://clang-format-configurator.site/, clang-format-15 is a default version, then scroll to any +, for example AttributeMacros, and press +. The result is like in the issue description.

Wirena commented 1 year ago

@sergio-nsk I couldnt reproduce this problem, you do press blue plus button after the grey one, right?

optionSelection

sergio-nsk commented 1 year ago

So, I have to press [ + ] twice to get it working. It's very unintuitive use case, unexpected behavior. Could you improve it?

Wirena commented 1 year ago

@sergio-nsk Fixed it in 2d8bfac. Initially I thought that there's a difference between how clang-format interprets empty array options and undefined array options, but I was wrong, so having a button to create empty array does not make sence