search

WiresoulStudio / W_Mesh_28x

Blender addon for parametric objects
GNU General Public License v3.0
233 stars 21 forks source link

Fix smooth checkbox and stop referencing removed fields #5

Open mucrow opened 3 months ago

mucrow commented 3 months ago

auto smooth was removed, so creating a mesh causes a python error. i have fixed that.

also, smoothing wasn't linked to the smooth checkbox in the first place, so i added that as well

MetinSeven commented 3 months ago

Thanks for the fixes. Will there be an updated release, or should I use Code button ➔ Download Zip from the main page?

mucrow commented 3 months ago

hi @MetinSeven . i'm a random contributer from the internet (i.e., not a maintainer of this repository).

in order for this to be available on the main page, a maintainer at @WiresoulStudio needs to merge my changes and then create a new release.

you can download a zip of my branch, which i will link below, but please be warned that you should always exercise caution when downloading code from random folks on github, myself included lol. i dont have any real method or motivation to demonstrate that you should trust me, but i want folks to know about the risks.

https://github.com/mucrow/W_Mesh_28x/tree/fix-smooth-features

MetinSeven commented 3 months ago

Great, thanks, much appreciated! 👍

mucrow commented 2 months ago

previously, i had copied that logic into the cone and ring primitives too, but they don't have a "smoothed" parameter so it was causing people errors. i have fixed this on my branch.