WTG1001:DoNotUsePrivateKeyword should ignore partial methods with non-void return types

[wtg-mg8]

WTG1001:Do not use the 'private' keyword analyzer is raising a diagnostic for partial methods to remove the private accessibility modifier when doing so causes the compiler to emit error CS8796: Partial method must have accessibility modifiers because it has a non-void return type.

Given the following class

partial class Testing
{
    [GeneratedRegex("abc|def", RegexOptions.IgnoreCase, "en-US")]
    static partial System.Text.RegularExpressions.Regex AbcOrDefGeneratedRegex();
}

Compiler will error: CS8796: Partial method 'Testing.AbcOrDefGeneratedRegex()' must have accessibility modifiers because it has a non-void return type.

Expected outcome: WTG1001 analyzer should not prompt to remove private from non-void return partial methods.

Forgot to mention: this was raised to me by Oleh Miroshnychenko (@oleh-wtg).

Corresponds to WI00764889

[yaakov-h]

Duplicate of #205.

We already have unit tests and logic that account for this:

• This is already covered in the Partial test suite.
• We also have an early return here for when the partial keyword is present on a method declaration: https://github.com/WiseTechGlobal/WTG.Analyzers/blob/02fccc99605e35905f938586f188ad490282b3ac/src/WTG.Analyzers/Analyzers/Visibility/VisibilityAnalyzer.cs#L50-L51

This was fixed in #206 which shipped in WTG.Analyzers package version 3.7.2.

If you're still using an older analyzers version I suggest updating. 😉

[oleh-wtg]

[like] Oleh Miroshnychenko reacted to your message:

---

From: Yaakov @.> Sent: Monday, July 1, 2024 8:20:45 AM To: WiseTechGlobal/WTG.Analyzers @.> Cc: Oleh Miroshnychenko @.>; Mention @.> Subject: Re: [WiseTechGlobal/WTG.Analyzers] WTG1001:DoNotUsePrivateKeyword should ignore partial methods with non-void return types (Issue #220)

You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification ⚠ CAUTION: This email originated from outside of the organisation. Do not click on links or open attachments in emails unless you are sure it is from a trusted sender and was expected.

Duplicate of #205https://github.com/WiseTechGlobal/WTG.Analyzers/issues/205.

We already have unit tests and logic that account for this:

• This is already covered in the Partialhttps://github.com/WiseTechGlobal/WTG.Analyzers/tree/02fccc99605e35905f938586f188ad490282b3ac/src/WTG.Analyzers.Test/TestData/VisibilityAnalyzer/Partial test suite.
• We also have an early return here for when the partial keyword is present on a method declaration: https://github.com/WiseTechGlobal/WTG.Analyzers/blob/02fccc99605e35905f938586f188ad490282b3ac/src/WTG.Analyzers/Analyzers/Visibility/VisibilityAnalyzer.cs#L50-L51

This was fixed in #206https://github.com/WiseTechGlobal/WTG.Analyzers/pull/206 which shipped in WTG.Analyzers package version 3.7.2.

If you're still using an older analyzers version I suggest updating. 😉

— Reply to this email directly, view it on GitHubhttps://github.com/WiseTechGlobal/WTG.Analyzers/issues/220#issuecomment-2199531909, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BDHSNMRGVZBM5BPFS3MVJ3TZKEGN3AVCNFSM6AAAAABJ67G7EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJZGUZTCOJQHE. You are receiving this because you were mentioned.Message ID: @.***>