WispSSBM / ProjectPunch

MIT License
13 stars 1 forks source link

lucas shield adv issue #3

Open pkzstar opened 3 months ago

pkzstar commented 3 months ago

unsure if a bug or if the lads just messed up but nair shows -4 (which it should) but sometimes shows 11 for no apparent reason, also grounded mag doesn't take into account jumpsquat.

nair video https://streamable.com/sookwb

WispSSBM commented 2 months ago

I figured out why this happens... shield stun actually runs out on landing sometimes and on the same frame the last hit of nair refreshes shield, causing the my stuff to think that sheik was actionable on that frame, since she went through a guarddamage->guard->guarddamage state sequence in one frame. This is a nice edge case to find :) Specifically what's happening here is that if there is the max # of frames between lucas's nair hits and his landing hitbox this will occur.

As for grounded mag + jumpsquat, tools like unclepunch don't take jumpsquat into account for situations like shine. For the purpose of this tool, advantage on hit is always considered without jumpsquat. It wouldn't really even make sense to do otherwise, since lucas still has jump-cancellable options out of mag afaik which skip a variable amount of the jumpsquat frames based on your execution.

Thanks for trying the tool and the bug report :+1: