search

Wizcorp / node-graylog2

Graylog2 client library for Node.js
Other
59 stars 36 forks source link

Doesn't close doesn't destroy if nothing to send #13

Closed ghost closed 7 years ago

ghost commented 9 years ago

The .close method does not actually close the connection and call a possible callback if no unsent messages/chunks are left.

ronkorving commented 9 years ago

Ouch, that's a problem. Mind sending a PR to address this?

stelcheck commented 9 years ago

Looks like there is a PR for that, and one that has been up since April. Already pinged it, suggest you have a second look at it.

ronkorving commented 9 years ago

I think that's a different issue.

ghost commented 9 years ago

Created a PR, @ronkorving .

ronkorving commented 9 years ago

Thanks!

ronkorving commented 9 years ago

Is it me or...? I don't see it.