Complete re-implementation

[ronkorving]

Improvements:

• Performance improvements (seems to be up to one order of magnitude).
• Clean new architecture.
• Clearer separation between public and private properties.
• Fewer buffer allocations.
• More graceful client.close behavior.
• The UDP socket is unref'ed to allow automatic process shutdown.
• You can now var Graylog = require('graylog');, no more need (although still supported) for a property lookup.
• You can track how much has been compressed and sent, through the logger.compressed and logger.sent integers (undocumented, but quite useful during tests).
• ReadMe updates.
• Test coverage (all but 3 lines are covered).

Changes:

• logger.config is no longer exposed.
• Requires Node 5.7.0 or later (ie: major version bump)

TODO:

• JSHint is not aggressive enough. Maybe switch to ESLint while we're at it.

cc @stelcheck @slang800

Closes #10 Closes #21 This should also make #19 behave better (please confirm, @jasonmcaffee). This should fix #16 (please confirm, @navihtot)

[stelcheck]

The UDP socket is unref'ed to allow automatic process shutdown.

Wouldn't this also mean that buffered messages might not get sent?

[ronkorving]

No, all messages in the queue will get sent (since there are events preventing the process from shutting down for as long as there are messages that haven't yet been sent). The moment the queue is empty, the logger emits a drain event to which it responds itself by closing the socket.

[navihtot]

@ronkorving I'm not using this lib anymore in my project, so I don't have an simple way to check for #16

[ronkorving]

@navihtot Understood. Thanks for checking in though :)

[Fl4m3Ph03n1x]

I am using this lib, is there a way I can test out or somehow help?

[ronkorving]

@Fl4m3Ph03n1x I'm no longer using it these days, so am afraid I don't have the tools at my disposal nor the time to take this PR to completion. If you want, you could pull in this branch and take ownership by taking it to its conclusion.

[Fl4m3Ph03n1x]

@ronkorving Ahhh, this is confusing to me. Who will then update the project on NPM? I don't have the permissions to do it, even if I complete the PR, it will be useless.

Can I at least be added as a collaborator for NPM if I take ownership of the project? ( that's what we are talking about here, right ? )

[ronkorving]

@stelcheck can update the project on NPM, as can I.

I'm perfectly happy with more maintainers (a landable PR will sell that :)), but @stelcheck will also have to be in agreement with adding maintainers. I was talking about taking ownership of this PR.

[Fl4m3Ph03n1x]

I will see what I can do. So far the one thing I don't get is how to get a hold on the PR. I suppose I would fork the project and then what?

[ronkorving]

1. Make a fork of this project.
2. git checkout -b ronkorving-refactor2 master
3. Make any changes that need to be made, test, commit.
4. git push origin ronkorving-refactor2
5. Make a new pull request from your ronkorving-refactor2 branch to this repository.

[Fl4m3Ph03n1x]

Thanks, I'll see what I can do! Hopefully I am up for the task!

[ronkorving]

Good luck!

[DomiiBunn]

I think you should just publish the fork as just graylog package.

At this point your version seems better and this is unmaintained.